/icons/ folder cleansing crusade part 3 #83420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves medicart.dmi to /obj/medical/ because, duh. Moves restraints.dmi to /obj/weapons/ (before you hurr durr, shields, hands, grenades and turrets are also there, so...) Blackmarket caller, pda's, laptops and mining radios and mauna mug now belong to /obj/devices/ due to all being devices
cleans a stray pixel on biting icon in telegraph.dmi Moves mecha_ammo.dmi to /obj/weapons/guns/ where the regular ammmo is. Moves mecha_equipment.dmi to /obj/devices/ because they are. Moves all other mecha-related files from /mob/ to /mob/rideables along with moving vehicles.dmi there from /obj/ Removes an impostor pets.dmi and pets_held().dmi files from /mob/
beach.dmi's land into /obj/fluff/ language and pepe travel to /ui_icons/chat/ along with emoji.dmi from /ui_icons/emoji/ to remove bit of redundancy. buildmode.dmi and pic_in_pic.dmi move to /hud/ clickbox.dmi to /ui_icons/ everything else, for now, to icons/testing/
YesterdaysPromise
requested review from
Jacquerel,
san7890,
tralezab,
Imaginos16,
Krysonism,
Twaticus,
Wallemations,
EOBGames,
Maurukas,
MMMiracles,
ShizCalev,
LemonInTheDark,
JohnFulpWillard,
Fikou and
ExcessiveUseOfCobblestone
as code owners
tgstation-server
added
Sprites
moves creampie.dmi out from /effects/ to /mob/effects/ moves halo.dmi out from effects/cult/ to /mob/effects/ renames effects.dmi in /effects/cult/ to cult.dmi and moves it to /effects/, which makes /effects/cult/ empty and deleted renames effects_rcd.dmi to just rcd.dmi, 'effects' part is already covered in its path.
both loose '_icons' too. I would also change ui_icons to ui, but given how much files that'd affect, next time.
tralezab
approved these changes
May 24, 2024
|
Do not trust pluto posters.. |
|
This was test merged on manuel @ ~70pop. It seems the test merge bot did not detect it. There hasn't been any reported broken icons. |
comfyorange
added a commit
that referenced
this pull request
May 26, 2024
|
When making this pr you forgot to edit the filepath for the icon of the game window. (interface.dmf) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
In my effort to make the /icons/ folder cleaner and more intuitive instead of having to rely on recalling names of stuff and looking them up in code to find them for poor sods such as myself, plus in spurt of complusion to organize stuff, here goes. I've tracked all changes in commit descriptions. A lot still to be done, but I know these waves go over dozens of files making things slow, so went lighter on it. Destroyed useless impostor files taking up space and cleaned a stray pixel on my way.
Why It's Good For The Game
Cleaner /icons/ file means saner spriters, less time spent. Stray pixels and impostor files (ones which are copies of actually used ones elsewhere) are not good.
Changelog
🆑
image: Cleaned a single stray pixel in a single frame of a bite telegraphing accidentaly found while re-organizing the files.
/:cl: