-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports VG's Plasmamen + Species breathing additions #9220
Ports VG's Plasmamen + Species breathing additions #9220
Conversation
Pictures pl0x? |
|
||
/obj/screen/alert/not_enough_tox | ||
name = "Choking (No Plasma)" | ||
desc = "You're not getting enough plama. Find some good air before you pass out!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plasma* instead of plama
We skelebones now |
Perhaps for consistency's sake we should have it where lacking oxygen or co2 or plasma it should be black, where as having too much it should be red, so it fits in with pressure warnings. Also I'll make it so these are now the new default skeleton shapes, assuming they fit in the standard human clothing, since these are EXTRA SPOOKY. |
@WJohn you can art overhaul the sprites for the alerts at any time, at the moment, they work and don't look poopy, that's fine. |
Done already, it'd be a piece of cake to put these in in this PR: http://www.mediafire.com/download/d4jf9w8g2tcifni/SKELETONS.rar |
…as is red (inverse from previous commits), Skeletons now look like white plasmamen, to fit the theme, spooky.
@WJohn Implemented, thankies. |
maybe one day...maybe.... one can hope... |
Wait are these skeletons that need plasma to breathe and set plasma on fire when not in a suit. they probably need to get reduced fire damage at some level or i don't see them lasting long. |
@Supermichael777 the way they work on VG, they spawn in job specific versions of their suit (for a future PR) which is usually the only suit they'll ever need. |
stupid idea and stupid excuse to make skelebones a meme |
Stop hatin' on everything. |
Add the possibility to find their suits on the asteroid in an artifact room. Also can you turn into one using a green slime? If so how would you survive |
Also, I'm slightly curious. How does this work with oxygen tanks like on mining or what you may get out of an O2 locker? Would they all become dangerous? |
Oxygen is not innately harmful to Plasmamen (via breathing, if they're in an oxygenated environment with no suit on, they instantly ignite), they just need to breath plasma instead. But they'll make fun spookies for now. |
I meant for humans, does too much oxygen hurt them? How does this affect oxy tanks found everywhere? |
I think he means where you say 'they can have to much oxygen' then list humans as one of the species effected by this. So will pure oxygen negatively effect people or what? |
Oh No no, if you read the PR OP, having "too much" oxygen, is just because oxygen didn't have a "too much" where as plasma and co2 had "too much" but not a "too little" it's just for customisability, and was trivial to implement. @Lumipharon |
This is great. |
According to wikipedia, oxygen toxicity can have effects at 200-300kpa of pure oxygen. After like, 3 hours of exposure. I wouldn't worry about, just needless complication. |
No such thing as admin only when it comes to mutantraces, as the staff of change will still have a slight chance to pick it. It be an intensely unlucky roll to experience, under a 1% chance, but then that's just how magic is. The magic mirror could also technically be used to go plasmaman, but that seems like the kind of mistake a person would only make once. The new unstable mutantion toxin will probably need to blacklist these races. Also we have exotic blood, make em bleed plasma! |
That's a great idea, actually. Though at the same time they're skeletons, so there's not exactly much blood I could imagine in em. |
g i m m i c k |
Does this mean we got vox someday |
@Lumipharon Oki doki, pointless then. @Incoming5643 Again, it's admin only, or a rare punishment, without the suit nobody in their right mind should pick burny skeleton man. Also as to exotic blood @WJohn sums it up with "They're skeletons" Coming when I get home:
|
@WJohn I've got a long boring task that I couldn't complete myself to do with sprites: so if you'd please :3 Also that's technically a stretch goal, what we have now works, it's just not nice and generic. |
…) to not having enough oxygen. Plasmamen now heal brute and burn damage from the plasma reagent.
CHANGES:
|
bad idea |
Well ok then you've officially invalidated your feedback. |
http://www.mediafire.com/download/d4jf9w8g2tcifni/SKELETONS.rar Here you go. Honestly now that I look at it, I feel like this should just replace the regular fire overlay sprite I made like 3ish years ago, it's hideously outdated. This should also help make your code cleaner if there's only just one fire overlay everyone shares again. |
you wanna know why its bad? |
Need I go on? |
We have plantmen, shadowmen, golem people, adamantine people and so on. These are all very rare too, but there's no need to throw them out. SS13 is absolutely FULL of gimmicks, pudl. What's wrong with adding another one? |
…n fire underlay code - Thanks WJohnston!
"how does any organic life form survive without oxygen" lol |
Also as an additional stretch goal for this PR, since you're touching on being able to be set on fire and made the original "people can spread fire onto others" PR, could you make it so fire eventually stops burning on a corpse after a while? Right now you can catch fire from corpses that have been on the floor and on fire for the past half an hour, and it's really annoying. |
@WJohn not really in scope. |
Can I just make a silly "MUH EMMULSIONS" request here? Okay... So. ...Also breathing out O2 means they'd gradually become more and more flammable in their own atmosphere, which is silly amounts of dangerous. |
@Fayrik oh that's true, I didn't even think that their own breathing would cause them to ignite, but it totally would. CO2 makes more sense then. Also it was only O2 because you have O2 Nitrogen and CO2 in the air, and I didn't think Nitrogen made sense. so it was a 50/50 choice. |
…mful to plasmamen (they ignite) 2: Burnmix outputs CO2
Silicon based lifeforms would breathe quartz i shit you not |
I think I'm going to add a Where's Waldo gimmick to irritate pudl. |
Awesome, this feels a whole lot better now that they're not just going to kill themselves by breathing. I must say, I wonder what happens when they're on unsimulated turf. Is there just an atmosphere that doesn't get changed, or does the breath check get skipped? |
I like this, but my only concern is giving C02 a warnining sign, it removes it's use as a way to stealthily choke people using atmos. |
@Fayrik I assume they don't breathe on those, since the gases their are "unsimulated" |
I have no idea what these will be used for but I'm pretty excited nonetheless |
fun |
When this is merged, I promise I will choke myself out on an unsimulated tile, just for you, @RemieRichards |
@Fayrik L-lewd |
Oh, I have one last request real quick. I just took a second look at the new on-fire sprites when testing it on humans, and noticed the yellow eyes on the sprite looked pretty ugly and were redundant since the plasma skeletons already had these. Would you mind replacing those with this version instead? |
@WJohn no because I already removed the yellow eyes :P |
Thanks <3 |
Ports VG's Plasmamen + Species breathing additions
Changes:
/datum/gas_mixture
proc.Stretch goals:
Disclaimer:
They do NOT spawn on station, they are an admin only thing at the moment.
Also, Fully tested:
Image reference: