Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps #181

Merged
merged 11 commits into from
Jun 13, 2023
Merged

deps #181

merged 11 commits into from
Jun 13, 2023

Conversation

layik
Copy link
Collaborator

@layik layik commented Jan 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b479d01) 47.84% compared to head (a981cc9) 47.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #181   +/-   ##
========================================
  Coverage    47.84%   47.84%           
========================================
  Files           49       49           
  Lines         2550     2550           
  Branches      1034     1034           
========================================
  Hits          1220     1220           
  Misses        1151     1151           
  Partials       179      179           
Flag Coverage Δ
unittests 47.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@layik
Copy link
Collaborator Author

layik commented Jun 4, 2023

So far:

  1. Avoided baseui solely to add separate commit with snapshot update now upgraded
  2. Avoided upgrading react-router* as things have moved on from history.js wrapper in source
  3. The jest configuration depends on the CRA stack and now addresses the jest ESM issue if not.
  4. Avoided upgrading testing-library/react as 13+ requires react 18 so stick with 12.x.x
  5. Avoided upgrading selenium-webdriver as it needs to be done in the e2e env using the app.

@layik
Copy link
Collaborator Author

layik commented Jun 4, 2023

Final tests on local app before merge.

@layik
Copy link
Collaborator Author

layik commented Jun 9, 2023

  • e2e test may not pass and has to be done on app actions.

@layik
Copy link
Collaborator Author

layik commented Jun 13, 2023

e2e passes locally on a981cc9

@layik layik merged commit f9057de into develop Jun 13, 2023
@layik layik deleted the deps branch June 13, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants