Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support table block in Instant Views #214

Closed
vkryl opened this issue Sep 4, 2022 · 0 comments · Fixed by #528
Closed

Support table block in Instant Views #214

vkryl opened this issue Sep 4, 2022 · 0 comments · Fixed by #528
Labels
task Issues that describe not an issue but the task

Comments

@vkryl
Copy link
Member

vkryl commented Sep 4, 2022

Currently Telegram X doesn't support TdApi.PageBlockTable, which makes some IVs unsupported. It is the only remaining IV block type that is unsupported by the app.

It could be implemented by using algorithms used in browser engines, or by relying on some JetPack/third-party existing component for tables, but as of the moment when this issue created it seems all ot them do not provide easy support for colspan and rowspan, especially when they are invalid.

TdApi.PageBlockTable can be frequently found in Wikipedia IVs, such as for this article in Commercial telegraphy section.

This issue can be used to track the progress on this feature and any potential implementation discussion.

This issue is PR-welcome as long as there's no assignee who's working on it.
@vkryl vkryl added task Issues that describe not an issue but the task feature and removed feature labels Sep 4, 2022
@Arseny271 Arseny271 mentioned this issue Jan 7, 2024
Merged
@vkryl vkryl linked a pull request Jan 13, 2024 that will close this issue
Support table block in Instant Views #528
Merged
vkryl added a commit that referenced this issue Jan 13, 2024
@Arseny271 @vkryl
Support table block in Instant Views (#528)
e6587a9 
* Implemented #214

* Fixed incorrect `FontMetricsInt.ascent` calculation

* Remove rudimentary `Text.getAscent` method

* Fix `Text.getFontMetrics`

* Avoid double index lookup when `FLAG_ALWAYS_BREAK` is set

* Revert `Text.locatePart`

* Rework `Text.locatePart`

* Properly fixed text size of `<sub>` and `<sup>` in IVs

---------

Co-authored-by: Vyacheslav <6242627+vkryl@users.noreply.github.com>
s3va pushed a commit to s3va/sevatgx that referenced this issue Apr 27, 2024
@Arseny271 @vkryl
Support table block in Instant Views (TGX-Android#528)
9889910 
* Implemented TGX-Android#214

* Fixed incorrect `FontMetricsInt.ascent` calculation

* Remove rudimentary `Text.getAscent` method

* Fix `Text.getFontMetrics`

* Avoid double index lookup when `FLAG_ALWAYS_BREAK` is set

* Revert `Text.locatePart`

* Rework `Text.locatePart`

* Properly fixed text size of `<sub>` and `<sup>` in IVs

---------

Co-authored-by: Vyacheslav <6242627+vkryl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Issues that describe not an issue but the task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support table block in Instant Views Arseny271/Telegram-X
1 participant
@vkryl