Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support table block in Instant Views #528

Merged
merged 26 commits into from
Jan 13, 2024
Merged

Support table block in Instant Views #528

merged 26 commits into from
Jan 13, 2024

Conversation

Arseny271
Copy link
Contributor

@vkryl vkryl linked an issue Jan 13, 2024 that may be closed by this pull request
Support table block in Instant Views #214
Closed
vkryl
vkryl requested changes Jan 13, 2024
View reviewed changes
app/src/main/java/org/thunderdog/challegram/util/text/TextPart.java Outdated Show resolved Hide resolved
app/src/main/java/org/thunderdog/challegram/ui/InstantViewController.java
return child == null || y < child.getTop() || y >= child.getBottom() || child.getLeft() >= 0;
ViewGroup vg = (ViewGroup) wrapView.getChildAt(0);
View child = vg.getChildAt(0);
return child == null || y < child.getTop() || y >= child.getBottom() || vg.getScrollX() == 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note: need to test slideshows)

app/src/main/java/org/thunderdog/challegram/util/text/Text.java Outdated Show resolved Hide resolved
@vkryl vkryl merged commit e6587a9 into TGX-Android:main Jan 13, 2024
s3va pushed a commit to s3va/sevatgx that referenced this pull request Apr 27, 2024
@Arseny271 @vkryl
Support table block in Instant Views (TGX-Android#528)
9889910 
* Implemented TGX-Android#214

* Fixed incorrect `FontMetricsInt.ascent` calculation

* Remove rudimentary `Text.getAscent` method

* Fix `Text.getFontMetrics`

* Avoid double index lookup when `FLAG_ALWAYS_BREAK` is set

* Revert `Text.locatePart`

* Rework `Text.locatePart`

* Properly fixed text size of `<sub>` and `<sup>` in IVs

---------

Co-authored-by: Vyacheslav <6242627+vkryl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkryl vkryl vkryl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support table block in Instant Views
2 participants
@Arseny271 @vkryl