Implement global package upgrade

README.md

@@ -72,6 +72,8 @@ If you want to check only a group of deps use these options:
 -o, --optional     Check only "optionalDependencies"
 ```
 
+Alternatively, you can use the `-g` (`--global`) flag to upgrade your global packages. **Note** that this flag is mutually exclusive and `npm-upgrade` will only recognise the global flag if supplied with others. Also **Note** that this option will automatically attempt to upgrade your global packages using `npm install -g <package>@<new-version>`.
+
 #### Ignoring module
 Sometimes you just want to ignore newer versions of some dependency for some reason. For example, you use `jquery v2` because of the old IE support and don't want `npm-upgrade` to suggest you updating it to `v3`. Or you use `some-funky-module@6.6.5` and know that the new version `6.6.6` contains a bug that breaks your app.
 

src/commands/check.js

@@ -11,7 +11,8 @@ import {colorizeDiff} from 'npm-check-updates/lib/version-util';
 
 import catchAsyncError from '../catchAsyncError';
 import {makeFilterFunction} from '../filterUtils';
-import {DEPS_GROUPS, createGlobalPackageJson, loadPackageJson, setModuleVersion, getModuleInfo, getModuleHomepage} from '../packageUtils';
+import {DEPS_GROUPS, loadGlobalPackages, loadPackageJson, setModuleVersion,
+  getModuleInfo, getModuleHomepage} from '../packageUtils';
 import {fetchRemoteDb, findModuleChangelogUrl} from '../changelogUtils';
 import {createSimpleTable} from '../cliTable';
 import {strong, success, attention} from '../cliStyles';
@@ -56,18 +57,15 @@ export const handler = catchAsyncError(async opts => {
   if (_.every(DEPS_GROUPS, ({name}) => !opts[name])) {
     _.each(DEPS_GROUPS, ({name}) => (opts[name] = true));
     opts.global = false;
-  }
-
-  // Make global flag mutually exclusive with other flags
-  else if (opts.global) {
-    for (let i = 0; i < DEPS_GROUPS.length; i++)
-      opts[DEPS_GROUPS[i].name] = false;
+  } else if (opts.global) {
+    // Make global flag mutually exclusive with other flags
+    for (let i = 0; i < DEPS_GROUPS.length; i++) {_.each(DEPS_GROUPS, ({name}) => { opts[name] = false })}
     opts.global = true;
   }
 
   // Loading `package.json` from the current directory
   const {path: packageFile, content: packageJson, source: packageSource} = opts.global ?
-    createGlobalPackageJson() : loadPackageJson();
+    loadGlobalPackages() : loadPackageJson();
 
   // Fetching remote changelogs db in background
   fetchRemoteDb();
@@ -78,7 +76,8 @@ export const handler = catchAsyncError(async opts => {
   const filteredWith = filter ? `filtered with ${strong(filter)} ` : '';
 
   console.log(
-    `Checking for outdated ${depsGroupsToCheckStr}dependencies ${filteredWith}${opts.global ? '' : (`for "${strong(packageFile)}"`)}...`
+    `Checking for outdated ${depsGroupsToCheckStr}dependencies ${filteredWith}${opts.global ? '' :
+      (`for "${strong(packageFile)}"`)}...`
   );
 
   const ncuDepGroups = DEPS_GROUPS
@@ -160,7 +159,8 @@ export const handler = catchAsyncError(async opts => {
 
     const answer = await askUser({
       type: 'list',
-      message: `${changelogUrl === undefined ? 'U' : 'So, u'}pdate "${name}" ${opts.global ? 'globally' : 'in package.json'} from ${from} to ${colorizeDiff(from, to)}?`,
+      message: `${changelogUrl === undefined ? 'U' : 'So, u'}pdate "${name}" ${opts.global ? 'globally' :
+        'in package.json'} from ${from} to ${colorizeDiff(from, to)}?`,
       choices: _.compact([
         {name: 'Yes', value: true},
         {name: 'No', value: false},
@@ -253,14 +253,12 @@ export const handler = catchAsyncError(async opts => {
     '\n'
   );
 
-  if (opts.global)
-  {
+  if (opts.global) {
     const shouldUpdateGlobalPackages = await askUser(
       {type: 'confirm', message: 'Update global modules?', default: true}
     );
 
-    if (!shouldUpdateGlobalPackages)
-      return;
+    if (!shouldUpdateGlobalPackages) {return}
 
     console.log(`Automatically upgrading ${updatedModules.length} module${updatedModules.length !== 1 ? 's' : ''}...`);
     return shell.exec(`npm install --global ${updatedModules.map(({name, to}) => `${name}@${to}`).join(' ')}`);

src/packageUtils.js

@@ -1,5 +1,5 @@
 import {resolve} from 'path';
-import {readFileSync, readdirSync, statSync} from 'fs';
+import {readFileSync} from 'fs';
 import libnpmconfig from 'libnpmconfig';
 import pacote from 'pacote';
 import shell from 'shelljs';
@@ -32,56 +32,21 @@ const getNpmConfig = _.memoize(() => {
   return config;
 });
 
-export function createGlobalPackageJson() {
-  // retrieve the global package install path
-  const res = shell.exec('npm root -g', {silent: true});
-  if (res.code !== 0)
-    throw new Error(`Could not determine npm's root path: ${res.stderr}`);
-
-  const globalPath = res.stdout?.replace('\n', '');
-  const pkg = { dependencies: {} };
-
-  function getPackageVersion(path)
-  {
-    try {
-      const packageSource = readFileSync(path, 'utf-8');
-      const packageJson = JSON.parse(packageSource);
-      if (packageJson.name && packageJson.version)
-        pkg.dependencies[packageJson.name] = packageJson.version;
-    } catch (err) {
-      // package.json doesn't exist for this global module
-      // or package.json couldn't be parsed
-    }
-  }
+export function loadGlobalPackages() {
+  const res = shell.exec('npm ls -g --depth 0 --json', {silent: true});
+  if (res.code !== 0) {throw new Error(`Could not determine global packages: ${res.stderr}`)}
 
   try {
-    const modules = readdirSync(globalPath);
-    for (const dir of modules)
-    {
-      const dirPath = resolve(globalPath, dir);
-      if (!statSync(dirPath).isDirectory())
-        continue;
-
-      if (dir.startsWith('@'))
-      {
-        const subModules = readdirSync(dirPath);
-        for (const subDir of subModules)
-        {
-          if (!statSync(resolve(dirPath, subDir)).isDirectory())
-            continue;
-
-          getPackageVersion(resolve(dirPath, subDir, 'package.json'));
-        }
-      }
-
-      else
-        getPackageVersion(resolve(dirPath, 'package.json'));
-    }
+    const {dependencies} = JSON.parse(res);
+    const content = {dependencies};
+
+    for (const [pkg, {version}] of Object.entries(dependencies)) {content.dependencies[pkg] = version}
+
+    return {content};
   } catch (err) {
-    console.error(err);
+    console.error(`Error parsing global packages: ${err.message}`);
+    process.exit(1);
   }
-
-  return {content: pkg};
 }
 
 export function loadPackageJson() {