Skip to content

Commit

Permalink
Update to go 1.19.1 to address CVE-2022-27664, CVE-2022-32190
Browse files Browse the repository at this point in the history
From the mailing list:

We have just released Go versions 1.19.1 and 1.18.6, minor point releases.
These minor releases include 2 security fixes following the security policy:

- net/http: handle server errors after sending GOAWAY
  A closing HTTP/2 server connection could hang forever waiting for a clean
  shutdown that was preempted by a subsequent fatal error. This failure mode
  could be exploited to cause a denial of service.

  Thanks to Bahruz Jabiyev, Tommaso Innocenti, Anthony Gavazzi, Steven Sprecher,
  and Kaan Onarlioglu for reporting this.

  This is CVE-2022-27664 and Go issue https://go.dev/issue/54658.

- net/url: JoinPath does not strip relative path components in all circumstances
  JoinPath and URL.JoinPath would not remove `../` path components appended to a
  relative path. For example, `JoinPath("https://go.dev", "../go")` returned the
  URL `https://go.dev/../go`, despite the JoinPath documentation stating that
  `../` path elements are cleaned from the result.

  Thanks to q0jt for reporting this issue.

  This is CVE-2022-32190 and Go issue https://go.dev/issue/54385.

Release notes:

go1.19.1 (released 2022-09-06) includes security fixes to the net/http and
net/url packages, as well as bug fixes to the compiler, the go command, the pprof
command, the linker, the runtime, and the crypto/tls and crypto/x509 packages.
See the Go 1.19.1 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.19.1+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  • Loading branch information
thaJeztah committed Sep 7, 2022
1 parent 58413c1 commit 1eadbdd
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 12 deletions.
13 changes: 5 additions & 8 deletions .github/workflows/.windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@ on:
default: false

env:
GO_VERSION: 1.19
# FIXME: temporarily using a separate var for this, as go-setup-action expects SemVer
# see https://github.com/actions/setup-go/tree/v3.2.0#supported-version-syntax
GO_VERSION_SEMVER: 1.19.0
GO_VERSION: 1.19.1
GOTESTLIST_VERSION: v0.2.0
TESTSTAT_VERSION: v0.1.3
WINDOWS_BASE_IMAGE: mcr.microsoft.com/windows/servercore
Expand Down Expand Up @@ -190,7 +187,7 @@ jobs:
name: Set up Go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION_SEMVER }}
go-version: ${{ env.GO_VERSION }}
-
name: Download artifacts
uses: actions/download-artifact@v3
Expand Down Expand Up @@ -218,7 +215,7 @@ jobs:
name: Set up Go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION_SEMVER }}
go-version: ${{ env.GO_VERSION }}
-
name: Install gotestlist
run:
Expand Down Expand Up @@ -390,7 +387,7 @@ jobs:
name: Set up Go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION_SEMVER }}
go-version: ${{ env.GO_VERSION }}
-
name: Test integration
if: matrix.test == './...'
Expand Down Expand Up @@ -480,7 +477,7 @@ jobs:
name: Set up Go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION_SEMVER }}
go-version: ${{ env.GO_VERSION }}
-
name: Download artifacts
uses: actions/download-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

ARG CROSS="false"
ARG SYSTEMD="false"
ARG GO_VERSION=1.19
ARG GO_VERSION=1.19.1
ARG DEBIAN_FRONTEND=noninteractive
ARG VPNKIT_VERSION=0.5.0

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.e2e
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.19
ARG GO_VERSION=1.19.1

FROM golang:${GO_VERSION}-alpine AS base
ENV GO111MODULE=off
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.simple
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

# This represents the bare minimum required to build and test Docker.

ARG GO_VERSION=1.19
ARG GO_VERSION=1.19.1

ARG BASE_DEBIAN_DISTRO="bullseye"
ARG GOLANG_IMAGE="golang:${GO_VERSION}-${BASE_DEBIAN_DISTRO}"
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.windows
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ FROM microsoft/windowsservercore
# Use PowerShell as the default shell
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

ARG GO_VERSION=1.19
ARG GO_VERSION=1.19.1
ARG GOTESTSUM_VERSION=v1.8.1
ARG GOWINRES_VERSION=v0.2.3
ARG CONTAINERD_VERSION=v1.6.8
Expand Down

0 comments on commit 1eadbdd

Please sign in to comment.