Skip to content

Commit

Permalink
Check uid ranges
Browse files Browse the repository at this point in the history
Fixes #5647
Docker-DCO-1.1-Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com> (github: LK4D4)
  • Loading branch information
LK4D4 committed May 18, 2014
1 parent 5e76f74 commit b64c71e
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions user/user.go
Expand Up @@ -9,6 +9,15 @@ import (
"strings"
)

const (
minId = 0
maxId = 1<<31 - 1 //for 32-bit systems compatibility
)

var (
ErrRange = fmt.Errorf("Uids and gids must be in range %d-%d", minId, maxId)
)

type User struct {
Name string
Pass string
Expand Down Expand Up @@ -194,6 +203,9 @@ func GetUserGroupSupplementary(userSpec string, defaultUid int, defaultGid int)
// not numeric - we have to bail
return 0, 0, nil, fmt.Errorf("Unable to find user %v", userArg)
}
if uid < minId || uid > maxId {
return 0, 0, nil, ErrRange
}

// if userArg couldn't be found in /etc/passwd but is numeric, just roll with it - this is legit
}
Expand Down Expand Up @@ -226,6 +238,9 @@ func GetUserGroupSupplementary(userSpec string, defaultUid int, defaultGid int)
// not numeric - we have to bail
return 0, 0, nil, fmt.Errorf("Unable to find group %v", groupArg)
}
if gid < minId || gid > maxId {
return 0, 0, nil, ErrRange
}

// if groupArg couldn't be found in /etc/group but is numeric, just roll with it - this is legit
}
Expand Down

0 comments on commit b64c71e

Please sign in to comment.