This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Merging in story 00 changes #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up after intergrating async bridge Split the descriptor out from networking impl. Ditch a load of unused event code Refactor Peer networking into manageable chunks Checkpoint: Solve problem of atomic update of peers Fix function I missed Complete the refactor of PeerNetworking Block scope doesn't work like thats Deal with server/client being different kinds of peer Fix up logging, invite timeout to 60 secs Improved logging, fixed relays Add protected mutable dict Fix parms mismatch Correct protected dict implementation Add stop method to relays Attempt to get server to notice client has gone
…t's what they really are
Story 0 tobybrad
…during delegate calls
Story 0 tobybrad
…lly deterministic
Story 0 tobybrad
Updating build commands
The new version of the first test in thaliscenarios assumes that we should get a networkChanged event when stopBroadcasting is called but that isn't how the API is supposed to work. The code also depended on a race condition where the call to startBroadcasting/stopBroadcasting and all their callbacks where in a tight loop that would effectively allow them to run serially even though they really should be in parallel.
Fixed test to work as advertised
Point NPM at master branch!
# Conflicts: # thali/install/install.js # thali/install/setUpTests.sh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just bringing story 001 up to date