Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Enhance CI to run iOS tests #771

Closed
yaronyg opened this issue Jul 19, 2016 · 15 comments
Closed

Enhance CI to run iOS tests #771

yaronyg opened this issue Jul 19, 2016 · 15 comments
Assignees
Milestone

Comments

@yaronyg
Copy link
Member

yaronyg commented Jul 19, 2016

This will require adding the code to detect when we are on iOS, run the tests and communicate the results to CI

@yaronyg yaronyg added this to the New Infra milestone Jul 19, 2016
@larryonoff larryonoff assigned larryonoff and unassigned baydet Jul 20, 2016
@yaronyg
Copy link
Member Author

yaronyg commented Jul 22, 2016

Working on figuring out how to integrate the tests into Cordova.

@larryonoff
Copy link
Contributor

Started work in the branch vNext_ilya_771

@yaronyg
Copy link
Member Author

yaronyg commented Jul 22, 2016

The next step is to create a cordova plugin with the iOS code inside of the test sub-folder

@yaronyg
Copy link
Member Author

yaronyg commented Jul 25, 2016

We still need to modify the XCode file generated by Cordova because we need an embedded framework and that currently isn't supported by Cordova (there is a PR on it but it hasn't been accepted) and there are work arounds and we have to pick one.

@yaronyg
Copy link
Member Author

yaronyg commented Jul 25, 2016

Everything works now!

@yaronyg
Copy link
Member Author

yaronyg commented Jul 29, 2016

Before we were doing the set up work manually and now we are writing a script to automate and things are getting buggy.

@yaronyg
Copy link
Member Author

yaronyg commented Aug 2, 2016

We need some clean up on the code and then we will submit a PR.

@larryonoff
Copy link
Contributor

CI is outdated. Since It has

  • El Capitan
  • Xcode 7.2

We need the latest Xcode 7.3. So it can be an issue why builds aren't running on devices.

We're working on updating CI.

@larryonoff
Copy link
Contributor

CI was updated with Xcode 7.3. The issues still remains.

@yaronyg
Copy link
Member Author

yaronyg commented Aug 12, 2016

We seem to be having an issue with code signing but only in CI, not on any of the local machines. We aren't 100% sure this is true or not but it's our best theory. So we want to try to use Carthage because it handles part of the code signing.

Our problem is that we are using a dynamic library and such libraries can either be signed or not and right now we aren't signed. So either we need to become a static library or we have configured something wrong in dynamic signing.

But for Swift everything pretty much has to be dynamic so even if we fix the xctest framework problem this issue is going to come back.

@larryonoff
Copy link
Contributor

link to PR #818

@larryonoff
Copy link
Contributor

@yaronyg @jareksl I have an assumption how we can solve the issue.

Currently as I understand CI uses developer provisioning profile, so we need to try using AdHoc provisioning profile to build test app.

During the investigating this issue I run the command codesign --verify for two builds: CI build and my local build. As result CI build has CSSMERR_TP_NOT_TRUSTED error.

@larryonoff
Copy link
Contributor

@jareksl please check app bundle id in developer.apple.com. It looks that build.sh creates com.test.thalitest when developer portal has provisioning profile with id com.test.thalitet (without s in last word test).

@larryonoff
Copy link
Contributor

The error CSSMERR_TP_NOT_TRUSTED was solved.

@yaronyg
Copy link
Member Author

yaronyg commented Aug 24, 2016

Right now tests say they are passing when they are not. We need to figure out why and fix it.

@yaronyg yaronyg closed this as completed Aug 29, 2016
larryonoff added a commit that referenced this issue Aug 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants