Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Merge Story 0 into master #63

Merged
merged 129 commits into from
Oct 30, 2015
Merged

Merge Story 0 into master #63

merged 129 commits into from
Oct 30, 2015

Conversation

deadlyfingers
Copy link
Contributor

Update master with postcard app (story_0 branch)

Review on Reviewable

yaronyg and others added 30 commits May 14, 2015 16:45
Client - Cordova app
Server - Pouchdb-express based node app
Client - Cordova app
Server - Pouchdb-express based node app
Included the leveldown related files
deadlyfingers and others added 17 commits October 15, 2015 15:11
The main fix is to assign the mock object to `global.Mobile` rather than
to defining it with `var Mobile`, because otherwise, the definition would apply
only within the current module.

The trigger for the mockups was moved behind a more explicit MOCK_MOBILE
environment variable rather than NODE_ENV, because the latter is a fairly
commonly used and we don't want these mocks to accidentally apply, for example,
in a Cordova-based environment.

The readme is updated with steps needed after a fresh clone to be able to run
on localhost.

Fixes #58.
Make it easier to run on localhost.
Story 0 using thali module 2.0.1 to fix #60
@yaronyg
Copy link
Member

yaronyg commented Oct 26, 2015

@deadlyfingers - There is a merge conflict. You need to resolve that first.

@yaronyg
Copy link
Member

yaronyg commented Oct 27, 2015

10/27 - Needs to resolve merge conflicts (it's a theme!)

@yaronyg
Copy link
Member

yaronyg commented Oct 28, 2015

10/28 - No work on this today because of the website work. BTW this is for #233

@deadlyfingers
Copy link
Contributor Author

Using P4Merge for resolving conflicts but sometimes it joins left+right as one entity so you can't choose left or right separately... Any other merge tool suggestions?

deadlyfingers added a commit that referenced this pull request Oct 30, 2015
@deadlyfingers deadlyfingers merged commit 8eb128e into master Oct 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants