Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

adds handling of the /thali_ special processing #6

Merged
merged 1 commit into from
Apr 9, 2016

Conversation

cicorias
Copy link
Member

@cicorias cicorias commented Apr 8, 2016

provides a callback on the signature that caller provides
closes #5


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 94.118% when pulling 8f797db on thaliidhandling into e9e2674 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 94.34% when pulling 5ec17a7 on thaliidhandling into e9e2674 on master.

@yaronyg
Copy link
Member

yaronyg commented Apr 8, 2016

Reviewed 10 of 11 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


test/test-thali-callback.js, line 32 [r2] (raw file):
Could you please just add one more test where you submit a request that is syntactically correct and is the right method and object (e.g. all o.k. by the base acl)but where the ID does not match validId? just want to make sure that a false will be handled properly by the code.


Comments from Reviewable

@yaronyg yaronyg assigned cicorias and unassigned yaronyg Apr 8, 2016
provides a callback on the signature that caller provides
closes #5
@cicorias
Copy link
Member Author

cicorias commented Apr 8, 2016

Review status: 10 of 11 files reviewed at latest revision, 1 unresolved discussion.


test/test-thali-callback.js, line 32 [r2] (raw file):
Done.


Comments from Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 94.34% when pulling c725f36 on thaliidhandling into e9e2674 on master.

@yaronyg
Copy link
Member

yaronyg commented Apr 9, 2016

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@yaronyg yaronyg assigned cicorias and unassigned yaronyg Apr 9, 2016
@cicorias cicorias merged commit 9acd3bc into master Apr 9, 2016
@cicorias cicorias deleted the thaliidhandling branch April 9, 2016 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ACL handling and callback for /:db/_local/thali_:id
3 participants