-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for Term::ReadKey >= 2.37 #241
Conversation
As of Term::ReadKey v2.34, Pinto was unable to pull this module. In v2.37, the author added Term::ReadKey to the "provides" section of META.yml. This workaround fixes can_index() so that Pinto is able to index Term::ReadKey 2.37 or later. Fixes thaljef#240
Hi Michael, sorry for the long wait on this. The metadata for Term::ReadKey seems broken to me. I can't think of a reason why the metadata should say that |
thanks |
I left a comment over in jonathanstowe/TermReadKey#29 about this, I believe that the fix in the PR should be generalized for any case where the file is @mschout -- are you up for that or should I swing at it? |
Alternatively, a cleaner change might be to touch up |
@hartzell I'll update my workaround today with your suggestions. Thanks |
This treats dists that provide a package file of META.yml or META.json as simile's. This META.yml or .json is perfectly valid per the CPAN Meta Spec, but Pinto was unable to deal with it. This fixes pulling Term::ReadKey >= v2.37, and probably other modules as well. As a result, the Term::ReadKey specific workaround has been removed Added test case for pulling a dist where the provides file is either META.yml or META.json Fixes thaljef#240 Fixes thaljef#241
I removed the Term::ReadKey hack, and fixed it in is_simile as suggested. I also added a test case. |
It appears Travis-CI is broken (fails to fetch Dist::Zilla). All tests pass on my machine |
Merged. Thanks. I'll fix the Travis problems on the master branch. |
As of Term::ReadKey v2.34, Pinto was unable to pull this module. In
v2.37, the author added Term::ReadKey to the "provides" section of
META.yml. This workaround fixes can_index() so that Pinto is able to
index Term::ReadKey 2.37 or later.
Fixes #240