Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behavior of when to leave bar #27

Closed
tupaschoal opened this issue Sep 25, 2019 · 5 comments
Closed

Behavior of when to leave bar #27

tupaschoal opened this issue Sep 25, 2019 · 5 comments
Assignees
@araujoarthur0
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Milestone
v1.5.2

Comments

@tupaschoal
Copy link
Collaborator

I feel like the bar telling you when to leave should change in some way when you've punched in all entries for the day. I don't know what to do though, if it should be hidden, or just rewritten...
dunno
@tupaschoal tupaschoal changed the title When to leave bar Behavior of when to leave bar Sep 25, 2019
@thamara thamara added this to the Version 1.1.0 milestone Sep 25, 2019
@thamara thamara added the enhancement New feature or request label Sep 25, 2019
@thamara thamara removed this from the Version 1.1.0 milestone Sep 25, 2019
@thamara thamara added the hacktoberfest Hacktoberfest label Oct 12, 2019
@patrixxn
Copy link

Hey, I'd like to contribute my work herefore, may I ask you to grant me push access?

@tupaschoal
Copy link
Collaborator Author

@patrixxn you don't need to, you can just fork the repository and then submit a PR, that's what people normally do. This gist explains it well :)

@tupaschoal tupaschoal added the good first issue Good for newcomers label Oct 21, 2019
@thamara
Copy link
Owner

thamara commented Oct 30, 2019

An idea to solve this is to change the text displayed in the row by something like:

All done for today. Balance including today: -00:45

@araujoarthur0
Copy link
Collaborator

I want to work with this one :)

@thamara
Copy link
Owner

thamara commented May 8, 2020

I've assigned that to you. Have fun!

araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 8, 2020
@araujoarthur0
Fix thamara#27: Adding day balance on when to leave bar after day is …
5c239c2 
…done
@araujoarthur0 araujoarthur0 mentioned this issue May 8, 2020
Merged
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 9, 2020
@araujoarthur0
Fix thamara#27: Adding day balance on when to leave bar after day is …
6dd45cb 
…done
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 9, 2020
@araujoarthur0
Fix thamara#27: When to leave bar - Updating text
eaa6f0d
@thamara thamara closed this as completed in ae9854c May 9, 2020
thamara pushed a commit that referenced this issue May 9, 2020
@araujoarthur0 @thamara
Fix #27: When to leave bar - Updating text
317ae5d
@thamara thamara added this to the v1.5.2 milestone May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@araujoarthur0 araujoarthur0

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Milestone
v1.5.2
Development

No branches or pull requests
4 participants
@thamara @tupaschoal @araujoarthur0 @patrixxn