Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #27: Adding day balance on when to leave bar after day is done #222

Merged
merged 2 commits into from
May 9, 2020

Conversation

araujoarthur0
Copy link
Collaborator

@araujoarthur0 araujoarthur0 commented May 8, 2020

Related issue

#27: Behavior of when to leave bar

Context / Background

  • When all the fields are filled for the day, the "When to leave bar" starts to instead display a day balance and a message that the day is done for.

What change is being introduced by this PR?

  • How did you approach this problem?
    Added the new behavior on the function that updates the value of the "when to leave bar".
    There is now a new hidden div on the bar, and they get switched out when the day is done.

  • What changes did you make to achieve the goal?
    Changes in existing function to update value of "when to leave bar", new style for hidden divs.

  • What are the indirect and direct consequences of the change?
    People will get a clearer message after the day is done for, and be able to know their day balance.

How will this be tested?

  • How will you verify whether your changes worked as expected once merged?
    Fill up my day and see if it works :)

Sample of how it'll be:
image

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #222 into master will decrease coverage by 0.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   23.03%   22.63%   -0.40%     
==========================================
  Files          11       11              
  Lines         916      932      +16     
  Branches      172      174       +2     
==========================================
  Hits          211      211              
- Misses        605      619      +14     
- Partials      100      102       +2     
Impacted Files Coverage Δ
js/calendar.js 0.00% <0.00%> (ø)
main.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4572e74...eaa6f0d. Read the comment docs.

Copy link
Owner

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change :)

js/calendar.js Outdated Show resolved Hide resolved
@thamara thamara merged commit 317ae5d into thamara:master May 9, 2020
@thamara thamara added this to the v1.5.2 milestone May 9, 2020
@araujoarthur0 araujoarthur0 deleted the when-to-leave branch May 10, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants