Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ES6 import statements along with node require() #806

Closed
araujoarthur0 opened this issue Oct 30, 2021 · 0 comments · Fixed by #807
Closed

Allow ES6 import statements along with node require() #806

araujoarthur0 opened this issue Oct 30, 2021 · 0 comments · Fixed by #807
Assignees
@araujoarthur0
Labels
enhancement New feature or request

Comments

@araujoarthur0
Copy link
Collaborator

Describe the current limitation
Allow ES6 import statements along with node require().
The renderer process is moving to be node-free, so we're using ES6 importing in it. The main process is still in node, and today it doesn't allow importing ES6 modules, so we're duplicating Utils code that could be used in both process.

Describe the proposed feature or enhancement
Using 'esm' module to allow ES6 import statements along with node require().

Additional context
This will enable better migrations of renderer code to the node-free context.
@araujoarthur0 araujoarthur0 added the enhancement New feature or request label Oct 30, 2021
@araujoarthur0 araujoarthur0 self-assigned this Oct 30, 2021
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 31, 2021
@araujoarthur0
Fix thamara#806: Using ES6 import in all modules used by renderer pro…
c4f68a2 
…cesses
@araujoarthur0 araujoarthur0 mentioned this issue Oct 31, 2021
Merged
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Nov 12, 2021
@araujoarthur0
Fix thamara#806: Using ES6 import in all modules used by renderer pro…
7ee8411 
…cesses
araujoarthur0 added a commit that referenced this issue Nov 24, 2021
@araujoarthur0
Fix #806: Using ES6 import in all modules used by renderer processes
8466ced
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Jan 20, 2022
@araujoarthur0
Fix thamara#806: Using ES6 import in all modules used by renderer pro…
e5a66d7 
…cesses
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 4, 2022
@araujoarthur0
Fix thamara#806: Using ES6 import in all modules used by renderer pro…
48ef88d 
…cesses
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 25, 2022
@araujoarthur0
Fix thamara#806: Using ES6 import in all modules used by renderer pro…
574f1d2 
…cesses
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 6, 2023
@araujoarthur0
Fix thamara#806: Using ES6 import in all modules used by renderer pro…
60ecc4f 
…cesses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@araujoarthur0 araujoarthur0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow ES6 import statements along with node require() araujoarthur0/time-to-leave
1 participant
@araujoarthur0