Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for preferences['count-today'] after checking for current date #213

Merged
merged 1 commit into from
Apr 19, 2020
Merged

add check for preferences['count-today'] after checking for current date #213

merged 1 commit into from
Apr 19, 2020

Conversation

NetizenAbel
Copy link
Collaborator

Related issue

#210

Context / Background

  • Currently, there is a bug wherein the count-today preference is not respected, as if always on.

What change is being introduced by this PR?

  • Add check for preferences['count-today'] after checking for current date.

How will this be tested?

  1. Log all the hours in the current day
  2. Notice the total changing, but not the balance
  3. Toggle it off/on
  4. Close preference window
  5. See that it changes

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   23.03%   23.03%           
=======================================
  Files          11       11           
  Lines         916      916           
  Branches      172      172           
=======================================
  Hits          211      211           
  Misses        605      605           
  Partials      100      100           
Impacted Files Coverage Δ
js/calendar.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba45d52...7fc4e4a. Read the comment docs.

@thamara thamara merged commit 8d2d9d6 into thamara:master Apr 19, 2020
@thamara thamara added this to the v1.5.2 milestone Apr 19, 2020
@NetizenAbel NetizenAbel deleted the issue/210 branch April 27, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants