DevTools shortcut on Preferences and Waiver windows #254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 56.18% 55.08% -1.11%
==========================================
Files 12 13 +1
Lines 1196 1220 +24
Branches 214 218 +4
==========================================
Hits 672 672
- Misses 460 480 +20
- Partials 64 68 +4
Continue to review full report at Codecov.
|
araujoarthur0
force-pushed
the
other-windows-dev-tools
branch
from
641d83e
to
564332f
Compare
|
Added a new window-aux.js file with the devtools binding function. |
araujoarthur0
force-pushed
the
other-windows-dev-tools
branch
from
564332f
to
4498c56
Compare
| @@ -14,6 +14,7 @@ | |||
| - Fix: [#250] Silently ignoring waiver on non-working day or non-working day range | |||
| - Enhancement: [#228] Improved performance of TTL - Now moving through the calendar is much faster | |||
| - Enhancement: [#152] Adding a "Copy" option in the "About message", making it easier to copy information when opening an issue | |||
| - Enhancement: [#245] DevTools shortcut on Preferences and Waiver windows | |||
There was a problem hiding this comment.
Can you squash this changelog commit with the first one? I think it also would be useful to say something like:
| - Enhancement: [#245] DevTools shortcut on Preferences and Waiver windows | |
| - Enhancement: [#245] DevTools shortcut (Ctrl+Shift+I) on Preferences and Waiver windows |
There was a problem hiding this comment.
You mean not having a separate commit for the changelog?
When accepting the merge request are you not able to squash them on demand? (real question, I've never accepted one hahaha)
There was a problem hiding this comment.
Yeah, I mean, you're basically changing the changelog (duh ahah) because of the first commit, so it should go together with it.
We can either squash them all together or have them all separate via the GitHub interface. We can squash portions using the CLI
There was a problem hiding this comment.
I've updated the changelog directly in master after merging the PR by mistake. (sorry again)
|
Sorry everyone, I got confused and merged the PR into master. |
|
Don't worry hahaha |
Related issue
#245
Context / Background
Adding DevTools shortcut on Preferences and Waiver windows.
What change is being introduced by this PR?
There's a new listener waiting for CTRL+SHIFT+I to be pressed in the preferences and waiver windows, to toggle chrome dev tools on those windows.
How will this be tested?
All working.