Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dev Tools on Waiver and Preference Windows #245

Closed
araujoarthur0 opened this issue May 27, 2020 · 6 comments
Closed

Allow Dev Tools on Waiver and Preference Windows #245

araujoarthur0 opened this issue May 27, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@araujoarthur0
Copy link
Collaborator

Describe the current limitation
Dev Tools doesn't open on waiver and preference windows => makes it harder to debug

Describe the proposed feature or enhancement
Using the suggestion presented here https://stackoverflow.com/a/37814569, I was able to trigger the opening of a dev tools on the waiver window. Perhaps we could either

  • attach the opening of dev tools to a keyboard shortcut
  • or add a menu tab when the app knows it's being opened from a dev environment

What do you think?

@araujoarthur0 araujoarthur0 added the enhancement New feature or request label May 27, 2020
@tupaschoal
Copy link
Collaborator

I'd be ok with it. We already have a shortcut for it on the main window "Ctrl + Shift + I", we could make it work everywhere

araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 31, 2020
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 31, 2020
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 31, 2020
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Jun 3, 2020
@araujoarthur0
Copy link
Collaborator Author

You can close this now

@tupaschoal
Copy link
Collaborator

@araujoarthur0 a tip: If you write "Closes #XXX" on your PR text when opening it, the issue is automatically closed when it gets merged :)

@araujoarthur0
Copy link
Collaborator Author

Oh, nice to know!

@araujoarthur0
Copy link
Collaborator Author

Could we update the template with this?

@tupaschoal
Copy link
Collaborator

Just did on #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants