Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #937: Add Ukrainian [uk-UA] localization #950

Merged
merged 24 commits into from
Feb 26, 2023
Merged

Close #937: Add Ukrainian [uk-UA] localization #950

merged 24 commits into from
Feb 26, 2023

Conversation

timagixe
Copy link
Contributor

Related issue

Closes #937

Context / Background

Adds Ukrainian localization

What change is being introduced by this PR?

Introduced localization into Ukrainian

How will this be tested?

  • added test for getLanguageName
  • I confirm I'm a native or fluent speaker of the language I'm translating to.

timagixe
timagixe commented Feb 23, 2023
View reviewed changes
Copy link
Contributor Author

@timagixe timagixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changs to README-he.md, README-sv-SE.md and js/windows.js were made during the pre-commit stage.

tupaschoal
tupaschoal requested changes Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great @timagixe, I have just a few comments with suggestions already.

__tests__/__main__/user-preferences.js Outdated Show resolved Hide resolved
docs/README-uk-UA.md Outdated Show resolved Hide resolved
src/configs/app.config.js Outdated Show resolved Hide resolved
timagixe and others added 4 commits February 25, 2023 14:34
@timagixe @tupaschoal
docs: remove badges from readme
f165acc 
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
@timagixe @tupaschoal
test: update list order
f4a114d 
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
@timagixe @tupaschoal
feat: update languages order in app config
121f81c 
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
@timagixe
style: lint fixes
e4ef46f
tupaschoal
tupaschoal approved these changes Feb 26, 2023
View reviewed changes
Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, I tested locally and found no issues. All tests ran locally passed too. Thanks @timagixe ! Do you want to be registered as the uk-UA translator so you can get notifications when a new string comes or changes?

@tupaschoal
Copy link
Collaborator

\changelog-update
Message: Translation: Time to Leave is now available in Ukrainian (uk-UA)!

@tupaschoal tupaschoal changed the title Add Ukrainian [uk-UA] localization Close #937: Add Ukrainian [uk-UA] localization Feb 26, 2023
@tupaschoal tupaschoal merged commit 680f594 into thamara:main Feb 26, 2023
@timagixe
Copy link
Contributor Author

Everything seems fine, I tested locally and found no issues. All tests ran locally passed too. Thanks @timagixe ! Do you want to be registered as the uk-UA translator so you can get notifications when a new string comes or changes?

@tupaschoal yes please, that would be nice. Thank you!

@tupaschoal
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupaschoal tupaschoal tupaschoal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend localizations with Ukrainian language
2 participants
@timagixe @tupaschoal