Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content field from _all.yml files are now loaded. #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayvdb
Copy link
Collaborator

@jayvdb jayvdb commented Nov 17, 2018

This is 44c12a9 from #67 , fixed up to avoid test failures.

I've not attempt to built test cases yet, as I suspect a bit more code is needed.

No doubt the commit message is correct that it allows _all.yml entries to contain a Content field.

But then shouldnt individual entry .yaml files also be able to have a Content field. It looks like the code doesnt allow for that yet.

@PaulPichaureau
Copy link
Contributor

Individual files have an implicit Content field, which is in fact the content of the file (the part of the file after the header).

@jayvdb
Copy link
Collaborator Author

jayvdb commented Nov 18, 2018

Hiya @PaulPichaureau , I was referring to individual .yaml files - I suspect they are able to have a Content field, from only a quick look at the code. If that is true, then that needs to be added, but I suspect that is a really easy fix. Last night I wsa only wanting to split PR 67 into two chunks which could be separately reviewed, enhanced and completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants