Skip to content

Commit

Permalink
HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Browse files Browse the repository at this point in the history
…ntAfterSplits (apache#1363)

  Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
  Signed-off-by: Viraj Jasani <vjasani@apache.org>
  Signed-off-by: <stack@apache.org>
  • Loading branch information
huaxiangsun authored and thangTang committed Apr 16, 2020
1 parent 26ce310 commit 85f9f95
Showing 1 changed file with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import org.apache.hadoop.hbase.HBaseTestingUtility;
import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.HRegionLocation;
import org.apache.hadoop.hbase.HTableDescriptor;
import org.apache.hadoop.hbase.ServerName;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;
Expand All @@ -51,6 +52,7 @@
import org.apache.hadoop.hbase.io.hfile.CachedBlock;
import org.apache.hadoop.hbase.io.hfile.CombinedBlockCache;
import org.apache.hadoop.hbase.io.hfile.bucket.BucketCache;
import org.apache.hadoop.hbase.regionserver.BloomType;
import org.apache.hadoop.hbase.regionserver.HRegion;
import org.apache.hadoop.hbase.regionserver.HStore;
import org.apache.hadoop.hbase.regionserver.InternalScanner;
Expand Down Expand Up @@ -573,7 +575,14 @@ public void testBlockRefCountAfterSplits() throws IOException, InterruptedExcept
Table table = null;
try {
final TableName tableName = TableName.valueOf(name.getMethodName());
table = TEST_UTIL.createTable(tableName, FAMILIES_1, 1, 1024);
HTableDescriptor desc = TEST_UTIL.createTableDescriptor(tableName);
// This test expects rpc refcount of cached data blocks to be 0 after split. After split,
// two daughter regions are opened and a compaction is scheduled to get rid of reference
// of the parent region hfiles. Compaction will increase refcount of cached data blocks by 1.
// It is flakey since compaction can kick in anytime. To solve this issue, table is created
// with compaction disabled.
desc.setCompactionEnabled(false);
table = TEST_UTIL.createTable(desc, FAMILIES_1, null, BloomType.ROW, 1024, null);
// get the block cache and region
RegionLocator locator = TEST_UTIL.getConnection().getRegionLocator(tableName);
String regionName = locator.getAllRegionLocations().get(0).getRegion().getEncodedName();
Expand Down

0 comments on commit 85f9f95

Please sign in to comment.