*: Relabel pod reference into instance label #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instance label is univesally used to refer to an instance in alerting rules and dashboards. To make it easy to identify in a Kubernetes environment it's most useful to relabel an identifier of the pod into the instance label. Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
brancz
force-pushed
the
pod-reference-instance
branch
from
b2b119e
to
e9824df
Compare
|
Before: After: |
|
Amazing 💯 thank you! So it works as expected :) |
squat
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The instance label is univesally used to refer to an instance in
alerting rules and dashboards. To make it easy to identify in a
Kubernetes environment it's most useful to relabel an identifier of the
pod into the instance label.
Do you think this needs a changelog entry?
Verification
Asking @metalmatze to apply this to a cluster as I'm opening this PR :)
@thanos-io/thanos-maintainers