Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receive: Extend configuration for labels #194

Merged
merged 3 commits into from
Mar 4, 2021
Merged

receive: Extend configuration for labels #194

merged 3 commits into from
Mar 4, 2021
+19 −9

Conversation

brancz
Copy link
Member

@brancz brancz commented Mar 4, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Allow configuring --label and --receive.tenant-label-name flags.

Verification

Generation works as expected in committed files.

@kakkoyun

@brancz
receive: Allow configuring labels
71f15c4 
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
@brancz
receive: Allow configuring --receive.tenant-label-name
e35202f 
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
@brancz
CHANGELOG.md: Add changelog entry
97293b1 
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
kakkoyun
kakkoyun approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@kakkoyun kakkoyun merged commit 452a9b3 into thanos-io:main Mar 4, 2021
@brancz brancz deleted the cfg branch March 4, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brancz @kakkoyun