Support scraping config-reloader sidecar for Thanos Ruler #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
force-pushed
the
mon-1085
branch
3 times, most recently
from
db7ac2d
to
338af9c
Compare
yeya24
approved these changes
Sep 2, 2021
philipgough
force-pushed
the
mon-1085
branch
2 times, most recently
from
d9de62a
to
5add2b9
Compare
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
philipgough
force-pushed
the
mon-1085
branch
from
5add2b9
to
64375d6
Compare
philipgough
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds config to allow scraping of the Thanos Ruler config reloader sidecar.
Verification
Deployed on minikube, look at the targets page and see thanos ruler with the desired endpoint is
up.