Add routerLabels to Receive router service #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-burt
force-pushed
the
receive-router-commonlabels
branch
2 times, most recently
from
0ee3405
to
7fc2f77
Compare
michael-burt
changed the title
michael-burt
force-pushed
the
receive-router-commonlabels
branch
2 times, most recently
from
e3b4846
to
d79ef9c
Compare
Signed-off-by: Michael Burt <michaelpburt@gmail.com>
michael-burt
force-pushed
the
receive-router-commonlabels
branch
from
d79ef9c
to
ee15f44
Compare
michael-burt
changed the title
kakkoyun
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the Thanos Receive router service to include the
routerLabelsincluded on other router resources. It also reformats the ports section and adds assertions that also exist for other service port declarations.Verification
I test this in a cluster and verified that it works.