kube-thanos: Allow PodDisruptionBudget minAvailable to be overridden #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
force-pushed
the
pdb-min-avail-override
branch
from
7db04dc
to
5fe17f1
Compare
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
brancz
force-pushed
the
pdb-min-avail-override
branch
from
5fe17f1
to
ce4b692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If replicas (for example in OpenShift templates) is not a number, but a string, then this calculation doesn't work, so it'd be good if we allow it to be overridden.
@squat @metalmatze @kakkoyun @bwplotka @krasi-georgiev