azure: Fix ignored options when creating shared credential Azure client #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
fix/azure-shared-key-opt
branch
2 times, most recently
from
7cce123
to
5623bbc
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
fix/azure-shared-key-opt
branch
from
5623bbc
to
5db0865
Compare
|
@ahurtaud could you build a fork with this branch of objstore and verify that it works for you? |
|
Sure I should be able to do this tomorrow. Otherwise on monday ;) |
|
@phillebaba I build thanos main + your objstore fix/azure-shared-key-opt branch and it works (tested thanos store only but I guess it'll work for all) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set client options when creating a Azure client with shared key. Before this the option was only set to clients using MSI authentication.
Verification
Should not require verification as the same option is passed to the MSI client.