Skip to content

Commit

Permalink
Fix 7244 error targets page (#7245)
Browse files Browse the repository at this point in the history
* added UNKNOWN to TargetHealth_value at targets proto

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>

* added TargetHealth_value UNKNOWN to rpc.pb.go

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>

---------

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>
  • Loading branch information
tizki committed Apr 8, 2024
1 parent 40465ee commit 6b3aa32
Show file tree
Hide file tree
Showing 3 changed files with 54 additions and 49 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
- [#7122](https://github.com/thanos-io/thanos/pull/7122) Store Gateway: Fix lazy expanded postings estimate base cardinality using posting group with remove keys.
- [#7224](https://github.com/thanos-io/thanos/pull/7224) Query-frontend: Add Redis username to the client configuration.
- [#7220](https://github.com/thanos-io/thanos/pull/7220) Store Gateway: Fix lazy expanded postings caching partial expanded postings and bug of estimating remove postings with non existent value. Added `PromQLSmith` based fuzz test to improve correctness.
- [#7244](https://github.com/thanos-io/thanos/pull/7244) Query: Fix Internal Server Error unknown targetHealth: "unknown" when trying to open the targets page.

### Added

Expand Down
101 changes: 52 additions & 49 deletions pkg/targets/targetspb/rpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/targets/targetspb/rpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ message TargetDiscovery {
enum TargetHealth {
DOWN = 0;
UP = 1;
UNKNOWN = 2;
}

message ActiveTarget {
Expand Down

0 comments on commit 6b3aa32

Please sign in to comment.