Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 7244 error targets page #7245

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix 7244 error targets page #7245

merged 2 commits into from
Apr 8, 2024

Conversation

tizki
Copy link
Contributor

@tizki tizki commented Mar 31, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@tizki tizki force-pushed the fix-7244-error-targets-page branch 2 times, most recently from 90d8d8f to 77e21e1 Compare March 31, 2024 19:00
@tizki
added UNKNOWN to TargetHealth_value at targets proto
2090bc0 
Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>
@tizki tizki force-pushed the fix-7244-error-targets-page branch from 77e21e1 to 2090bc0 Compare March 31, 2024 19:52
@tizki
added TargetHealth_value UNKNOWN to rpc.pb.go
2144f62 
Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>
MichaHoffmann
MichaHoffmann approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tizki
Copy link
Contributor Author

tizki commented Apr 8, 2024

I tested the fix and I can confirm it works.
sidecar and query were updated to use the code with the fix and I was able to see the unknown state in the UI. the page doesn't crash anymore.
image

@MichaHoffmann MichaHoffmann merged commit 6b3aa32 into thanos-io:main Apr 8, 2024
20 checks passed
jnyi pushed a commit to jnyi/thanos that referenced this pull request Jun 1, 2024
@tizki @jnyi
Fix 7244 error targets page (thanos-io#7245)
5ac1de3 
* added UNKNOWN to TargetHealth_value at targets proto

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>

* added TargetHealth_value UNKNOWN to rpc.pb.go

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>

---------

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>
jnyi pushed a commit to jnyi/thanos that referenced this pull request Jun 4, 2024
@tizki @jnyi
Fix 7244 error targets page (thanos-io#7245)
86fdd21 
* added UNKNOWN to TargetHealth_value at targets proto

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>

* added TargetHealth_value UNKNOWN to rpc.pb.go

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>

---------

Signed-off-by: Tidhar Klein Orbach <tizkiko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski fpetkovski approved these changes

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tizki @fpetkovski @MichaHoffmann