Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thanos receiver out of window support - seems to behave interesting #6040

Closed
farodin91 opened this issue Jan 12, 2023 · 0 comments · Fixed by #6044
Closed

Thanos receiver out of window support - seems to behave interesting #6040

farodin91 opened this issue Jan 12, 2023 · 0 comments · Fixed by #6044

Comments

@farodin91
Copy link
Contributor

Thanos, Prometheus and Golang version used: 0.30.1

Object Storage Provider: minio

What happened:
I set the out-of-window to 60s, if a value is outside of this windows thanos returns a 500 internal server error.

What you expected to happen:

I did expect it behaved with the same error code as before, if out-of-window is disable and you get an out of window metrices.

In general it should send an 409 or?

How to reproduce it (as minimally and precisely as possible):

Full logs to relevant components:

Anything else we need to know:
farodin91 added a commit to farodin91/thanos that referenced this issue Jan 13, 2023
@farodin91
mark ErrTooOldSample as SampleConflict error
206395d 
Fixes thanos-io#6040

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
@farodin91 farodin91 mentioned this issue Jan 13, 2023
Merged
2 tasks
farodin91 added a commit to farodin91/thanos that referenced this issue Jan 13, 2023
@farodin91
mark ErrTooOldSample as SampleConflict error
54a0414 
Fixes thanos-io#6040

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Kartik-Garg pushed a commit to infracloudio/thanos that referenced this issue Jan 16, 2023
@farodin91 @Kartik-Garg
mark ErrTooOldSample as SampleConflict error
cb83676 
Fixes thanos-io#6040

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
ngraham20 pushed a commit to ngraham20/thanos that referenced this issue Apr 17, 2023
@farodin91
mark ErrTooOldSample as SampleConflict error
7d4f3c2 
Fixes thanos-io#6040

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
ngraham20 pushed a commit to ngraham20/thanos that referenced this issue Apr 17, 2023
@farodin91
mark ErrTooOldSample as SampleConflict error
4702962 
Fixes thanos-io#6040

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mark ErrTooOldSample as SampleConflict error farodin91/thanos
1 participant
@farodin91