Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gossip code. #734

Closed
1 of 3 tasks
bwplotka opened this issue Jan 14, 2019 · 0 comments
Closed
1 of 3 tasks

Remove gossip code. #734

bwplotka opened this issue Jan 14, 2019 · 0 comments
Labels
feature request/improvement help wanted
Projects
v0.5.0

Comments

@bwplotka
Copy link
Member

bwplotka commented Jan 14, 2019 •
edited

As per approved design doc: https://github.com/improbable-eng/thanos/blob/master/docs/proposals/approved/201809_gossip-removal.md

We need to get advantage of not having gossip by removing it totally from project.

Action Items:

  • Add FileSD with DNS support
  • Announce removal on exact date
  • Remove Gossip code

The open question is: Should we make and example gossip sidecar in separate repo that uses FileSD as reference example? I don't think we will have time for this.. but help wanted (:
@bwplotka bwplotka added this to In progress in v0.4.0 Jan 14, 2019
@mleklund mleklund mentioned this issue Mar 28, 2019
Closed
@bwplotka bwplotka added this to To do in v0.5.0 via automation Apr 1, 2019
@bwplotka bwplotka removed this from In progress in v0.4.0 Apr 1, 2019
@povilasv povilasv moved this from To do to In progress in v0.5.0 Apr 10, 2019
@povilasv povilasv moved this from In progress to To do in v0.5.0 Apr 10, 2019
@povilasv povilasv mentioned this issue Apr 10, 2019
Merged
v0.5.0 automation moved this from To do to Done May 29, 2019
valyala added a commit to VictoriaMetrics/VictoriaMetrics that referenced this issue Jun 17, 2019
@valyala
README.md: use link to Wikipedia about broken gossip protocol instead…
0241707 
… of a link to document about Gossip protocol removal from Thanos

Thanos removed non-working gossip protocol a few months ago - thanos-io/thanos#734 ,
so the link to the design document https://github.com/improbable-eng/thanos/blob/master/docs/proposals/approved/201809_gossip-removal.md
became unavailable. So use a link to Wikipedia article instead.

Closes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request/improvement help wanted
Projects
No open projects
v0.5.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwplotka @povilasv