New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gossip #1008
Remove gossip #1008
Conversation
I plan to test this in dev on monday, Other than that, it's ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cannot find any blocker (: LGTM 馃敟
tested a bunch of components in my dev k8s cluster, it looks like it works :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM however we still have some references to gossip:
docs/component/{query,rule,sidecar,store}.md
:from other components if you use gossip,
I guess this part can just be removed. It comes fromcmd/thanos/flags.go
.pkg/query/storeset.go
has a log message talking about gossip:duplicated address in gossip or static store nodes
->duplicated address detected
. There's also a comment there talking about gossip. We should nuke it.pkg/store/prometheus.go
also has a small comment about gossip meta. We should remove it 馃挘
I guess it's not part of it but we should also remove gossip info from the example Grafana dashboards and the |
PTAL |
Issue: #1180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 馃憤
Love it! Let's get rid of it finally! |
馃帀 |
Changes
Remove gossip 馃敟
Issue
#734
Verification
Tests pass
Tested this in my k8s env, couldn't find a issue