Add a new prometheus.ready_timeout CLI option to the sidecar #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandesz
force-pushed
the
prometheus_ready_timeout_opt
branch
2 times, most recently
from
6b3685b
to
0be3bf8
Compare
|
Can you sign the commit as DCO bot suggests? (: |
The current timeout while the Prometheus instance is starting up is a constant 10 minutes. As reading the WAL can take a long time we would like to set a custom timeout value, so the Thanos sidecar container is not erroring out every 10 minutes. Signed-off-by: Andras Ferencz-Szabo <andrasferenczszabo@monzo.com>
bandesz
force-pushed
the
prometheus_ready_timeout_opt
branch
from
0be3bf8
to
fa1e935
Compare
|
@bwplotka sure, done! |
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
The current timeout while the Prometheus instance is starting up is a constant 10 minutes. As reading the WAL can take a long time we would like to set a custom timeout value, so the Thanos sidecar container is not erroring out every 10 minutes. Signed-off-by: Andras Ferencz-Szabo <andrasferenczszabo@monzo.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The current timeout while the Prometheus instance is starting up is a constant 10 minutes.
As reading the WAL can take a long time we would like to set a custom timeout value, so the Thanos sidecar container is not erroring out every 10 minutes.
Verification
I ran
make testwith the in-memory store tests.