Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Refetch series if longer than expected. #1985

Merged
merged 1 commit into from
Jan 12, 2020
Merged

store: Refetch series if longer than expected. #1985

merged 1 commit into from
Jan 12, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Jan 10, 2020

Fixes: #1983

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

cc @pracucci as we discussed this offline at some point (:

Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise lgtm

@@ -123,6 +122,10 @@ func (b *Bucket) GetRange(_ context.Context, name string, off, length int64) (io
return ioutil.NopCloser(bytes.NewReader(file[off:])), nil
}

if length <= 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error message does not agree with the condition here. Message says “smaller than 0” but the condition is <=0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Fixes: #1983

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fetch data after compaction
2 participants