cmd/thanos: Extract logger instantiation to pkg/logging #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
force-pushed
the
extract-logger
branch
from
7a7fbb1
to
ef0a3d0
Compare
squat
reviewed
Oct 20, 2020
pkg/logging/logger.go
Outdated
| case "debug": | ||
| lvl = level.AllowDebug() | ||
| default: | ||
| panic("unexpected log level") |
There was a problem hiding this comment.
I realize that we had the same behavior before, but I don't think that panicking is the right action to take when a user mistypes a flag. If this was only possible in a program error, then I would agree, but since it's possible when typing --log.level=eror I think it's too severe.
There was a problem hiding this comment.
Refactored this a bit, let me know what you think about this approach.
brancz
force-pushed
the
extract-logger
branch
from
ef0a3d0
to
011d665
Compare
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
brancz
force-pushed
the
extract-logger
branch
from
011d665
to
2cf68fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Extract logger instantiation to the
pkg/loggingpackage.Verification
Moved code, and still compiles :)
@thanos-io/thanos-maintainers