Compactor: Support disable block viewer UI

[wanjunlei]

Signed-off-by: wanjunlei wanjunlei@kubesphere.io

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

Add a new flag --web.disable for compactor, users can disable the block viewer UI of compactor using this flag

Verification

Run the compactor without --web.disable and access the URL localhost:19092, the bucket UI works.
Run the compactor with --web.disable and access the URL localhost:19092, it returns 404 page not found.

[yeya24]

Thanks for the pr. @wanjunlei What's the goal of this change? Do you want to disable the UI only?
I see you disable both the UI and the API now. Probably we can keep the API.

[wanjunlei]

Thanks for the pr. @wanjunlei What's the goal of this change? Do you want to disable the UI only? I see you disable both the UI and the API now. Probably we can keep the API.

The goal of this change is to reduce resource consumption, so I disable both the UI and the API.

[yeya24]

LGTM

[matej-g]

I'm not against this change in principle, but I'm wondering how many resources does turning it off saves 🤔. Do we have any numbers?

[yeya24]

Right now we don't have a way to change the interval of fetching metadata and it is hardcoded to 1m, which might be a little bit short. Considering a lot of users actually don't need a UI.

Another use case I can think of is about the delete and no compact marker on the UI. For security purpose I guess some users don't want to expose it.

[matej-g]

Thanks @yeya24 for the explanation, then it makes sense to add this 👍