Store: Support disable block viewer UI. #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Sep 28, 2022
cmd/thanos/store.go
Outdated
| if !conf.disableWeb { | ||
| compactorView := ui.NewBucketUI(logger, conf.webConfig.externalPrefix, conf.webConfig.prefixHeaderName, conf.component) | ||
| compactorView.Register(r, ins) | ||
| } |
There was a problem hiding this comment.
So you don't want to disable the api this time?
There was a problem hiding this comment.
What's the reason for this? We should be consistent with the compactor change.
There was a problem hiding this comment.
The reason is that disabling the API will not save more resources.
From a consistency point of view, disabling is also reasonable, I will change it.
yeya24
previously approved these changes
Sep 28, 2022
wanjunlei
force-pushed
the
main
branch
2 times, most recently
from
7c1bb93
to
ee79280
Compare
|
no new modifications, just to rerun the test |
matej-g
previously approved these changes
Sep 28, 2022
auto-merge was automatically disabled
September 29, 2022 00:56
Head branch was pushed to by a user without write access
Signed-off-by: wanjunlei <wanjunlei@kubesphere.io>
Resolved |
yeya24
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wanjunlei wanjunlei@kubesphere.io
Changes
Add a new flag --web.disable for store, users can disable the block viewer UI of store using this flag.
This pr is similar #5723 , but there are still some differences.
If the compactor running with
--web.disable, the block viewer UI and the bucket APIS will be disabled.If the store running with
--web.disable, only the block viewer UI will be disabled.The reason for this difference is the compactor bucket API uses a separate meta fetcher to sync the block meta, disable the bucket APIS can Reduce resource consumption. The store bucket APIS reuses the mete fetcher of buckets store, no additional resource consumption.
Verification