Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float histogram in store gateway #6925

Merged
merged 5 commits into from Nov 27, 2023
Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 26, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Add missing float histogram support to SG. Most of the code is the same as #6056

Verification

Updated unit test and E2E test

Signed-off-by: Ben Ye <benye@amazon.com>
fpetkovski
fpetkovski previously approved these changes Nov 26, 2023
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to fix lint

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
MichaHoffmann
MichaHoffmann previously approved these changes Nov 26, 2023
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24 yeya24 merged commit 9d6f82e into thanos-io:main Nov 27, 2023
20 checks passed
@yeya24 yeya24 deleted the float-histogram branch November 27, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants