Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule ui #894

Merged
merged 3 commits into from Mar 6, 2019
Merged

Fix rule ui #894

merged 3 commits into from Mar 6, 2019

Conversation

davtsur
Copy link
Contributor

@davtsur davtsur commented Mar 6, 2019 •
edited

Changes

Fixes #854

  1. Fixing rules.html to use GetEvaluationDuration
  2. Updated bindata.go

Verification

Tested UI locally

@davtsur davtsur mentioned this pull request Mar 6, 2019
Closed
bwplotka
bwplotka approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Super nice.

@bwplotka bwplotka merged commit bd3c1de into thanos-io:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davtsur @bwplotka