backmerging #1
Merged
backmerging #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/pkg/errors](https://github.com/pkg/errors) from 0.8.0 to 0.8.1. - [Release notes](https://github.com/pkg/errors/releases) - [Commits](pkg/errors@v0.8.0...v0.8.1) Signed-off-by: dependabot[bot] <support@dependabot.com>
* ran make * fmt fmt fmt
Bumps [github.com/grpc-ecosystem/go-grpc-prometheus](https://github.com/grpc-ecosystem/go-grpc-prometheus) from `93bf462` to `68e3a13`. - [Release notes](https://github.com/grpc-ecosystem/go-grpc-prometheus/releases) - [Commits](grpc-ecosystem/go-grpc-prometheus@93bf462...68e3a13) Signed-off-by: dependabot[bot] <support@dependabot.com>
* updating version * remove new line
* Removed old kube manifests with updated k8s tutorial based on demo. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Updated kubernetes-demo manifests to use improbable/thanos:v0.3.0 docker image instead of the rc. (#827) Signed-off-by: David Calvert <davidcalvertfr@gmail.com> * Fixed links. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Improved docs (#840) * Updated kubernetes-demo manifests to use improbable/thanos:v0.3.0 docker image instead of the rc. Signed-off-by: David Calvert <davidcalvertfr@gmail.com> * renamed thanos-gateway to thanos-store-gateway and fixed headless servicename in order to resolve dns. Signed-off-by: David Calvert <davidcalvertfr@gmail.com> * Updated docs/getting_started.md path for manifests/thanos-store-gateway.yaml Signed-off-by: David Calvert <davidcalvertfr@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Otherwise we can end up being in starvation. Reloader is trying to create config for Prometheus and shipper fails before that because Prometheus is not up. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
* Update README.md * Update README.md * Update README.md
* Adding new API end point for rules and alerts * reusing methods in query api * Adding unitest for rule API (similar to prometheus rule/alert API end point unitest) * Adding SetCORS * Removing comments * Related to issue #850
…873) * store/cache: do not forget to increase c.current on adding new items * store/cache: properly adjust c.curSize * store/cache: prevent uint64 overflow by switching operands Adding uint64(len(b)) to c.curSize might potentially overflow uint64 if the numbers are big enough and then we might not remove enough items from the LRU to satisfy the request. On the other hand, switching the operands avoids this problem because we check before if uint64(len(b)) is bigger than c.maxSize so subtracting uint64(len(b)) will *never* overflow because we know that it is less or equal to c.maxSize. * store/cache: revert ensureFits() changes c.curSize is lowered in onEvict. * store/cache: add smoke tests Add smoke tests for the index cache which check if we set curSize properly, and if removal works.
Make it more clear what the Prometheus command line flags should be for sidecar use.
It is possible that Prometheus will produce time series with duplicate
labels. E.g.: a{b="2",b="2"} 1
Where such metric is pushed to Prometheus either wittingly or
unwittingly, the compact process will stall because the check will not
pass. For example:
{"caller":"main.go:181","err":"error executing compaction: compaction failed: compaction: gather index issues for block /data/compact/0@{monitor="monitor",replica="repl"}/01D34EDQMSQ29RHAC47XGKHGC7: out-of-order label set {**name**="foo",exported_job="vv",host="172_16_226_56",host="172_16_226_56",region="lt",subtask_index="5",task_attempt_id="32e4b047bb768583ff57c709be3b1046",task_attempt_num="8",task_id="688c028a219ff3372f3eecb0ee5811f9",task_name="Source:_foo",tenant="abc",tier="cooltier",tm_id="53b2ed987b08f427dec4ee1465df91fa"} for series 2594231","level":"error","msg":"running command failed","ts":"2019-02-11T13:30:33.901722306Z"}
This commit fixes the mentioned issue. Amend the e2e test to test the
case when a series has identical labels.
* add concurrency to meta sync * fix test * update docs * address cr * use sentinel error to handle ignoring fresh blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification