[ENG-222] fees improve test coverage #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each deployer now has a KVStore for storing its registered contracts.
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
==========================================
+ Coverage 83.32% 85.67% +2.34%
==========================================
Files 116 117 +1
Lines 6376 6372 -4
==========================================
+ Hits 5313 5459 +146
+ Misses 935 784 -151
- Partials 128 129 +1
|
loredanacirstea
commented
May 11, 2022
loredanacirstea
requested review from
danburck,
fedekunze,
khoslaventures and
jolube
as code owners
Prosp3r
reviewed
May 11, 2022
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck
approved these changes
May 12, 2022
loredanacirstea
added a commit
that referenced
this pull request
May 14, 2022
* main: Correct inflation.proto typo (#608) change algolia search key (#607) Changing erroneous epoch skips to daily instead of weekly (#554) fix: remove dup set claims record + CLI update (#605) build(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (#604) imp: fees test coverage (#586) fees: limit address derivation to 20 iterations at registration (#603)
loredanacirstea
added a commit
to loredanacirstea/evmos
that referenced
this pull request
May 16, 2022
* main: Correct inflation.proto typo (evmos#608) change algolia search key (evmos#607) Changing erroneous epoch skips to daily instead of weekly (evmos#554) fix: remove dup set claims record + CLI update (evmos#605) build(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (evmos#604) imp: fees test coverage (evmos#586) fees: limit address derivation to 20 iterations at registration (evmos#603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[]byte("1")is used to show existence. This approach makes it easier to add, remove, iterate over all registered contracts of a deployer, compared to the original approach of storing an array of contract addresses for each deployer (all deployers in the same KVStore)types/params.go,types/codec.go,keeper/fees.go,keeper/grpc_query.goethermint.ValidateNonZeroAddressfor validationCloses: #552
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...