-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates redundancy #20
Comments
We should be able to delete all of the templates in /project_sample/templates/schedule/ right now and things will continue to work just fine (I think). The django.template.loaders.app_directories.load_template_source template loader should pick them up. It seems like if having a project_sample is useful, then we'd want any kind of re-usable template to go in schedule/templates/schedule and anything that's specific to that sample project can go in project_sample/templates. When I made the change originally, I didn't want to delete the templates in project_sample/templates/schedule without making sure that's what other people wanted to go with. Does the schedule/templates/schedule for re-usable templates and project_sample/templates/schedule for templates specific to that project make sense to others? |
I went ahead and committed my proposed change to my branch: http://github.com/winhamwr/django-schedule/commit/330bb549e42f3db3b88dfdcdaa7cfbf7673cacb9 The sample project functions just like it used to for me with the change. |
done upstream |
After Wes' Pinax-related restructuring we have the same templates in two places - in /schedule/templates/schedule/ and /project_sample/templates/schedule/. Can we clean it up, or is there a reason to keep it like that?
The text was updated successfully, but these errors were encountered: