Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates redundancy #20

Closed
bartekgorny opened this issue Sep 5, 2009 · 3 comments
Closed

Templates redundancy #20

bartekgorny opened this issue Sep 5, 2009 · 3 comments

Comments

@bartekgorny
Copy link
Collaborator

After Wes' Pinax-related restructuring we have the same templates in two places - in /schedule/templates/schedule/ and /project_sample/templates/schedule/. Can we clean it up, or is there a reason to keep it like that?

@winhamwr
Copy link
Contributor

winhamwr commented Sep 7, 2009

We should be able to delete all of the templates in /project_sample/templates/schedule/ right now and things will continue to work just fine (I think). The django.template.loaders.app_directories.load_template_source template loader should pick them up. It seems like if having a project_sample is useful, then we'd want any kind of re-usable template to go in schedule/templates/schedule and anything that's specific to that sample project can go in project_sample/templates.

When I made the change originally, I didn't want to delete the templates in project_sample/templates/schedule without making sure that's what other people wanted to go with. Does the schedule/templates/schedule for re-usable templates and project_sample/templates/schedule for templates specific to that project make sense to others?

@winhamwr
Copy link
Contributor

winhamwr commented Sep 7, 2009

I went ahead and committed my proposed change to my branch: http://github.com/winhamwr/django-schedule/commit/330bb549e42f3db3b88dfdcdaa7cfbf7673cacb9

The sample project functions just like it used to for me with the change.

@bartekgorny
Copy link
Collaborator Author

done upstream

boardman referenced this issue in boardman/django-schedule Nov 26, 2013
jrutila referenced this issue in jrutila/django-schedule Apr 13, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants