Hide Kiba classes from the ETL evaluation scope #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing Kiba 2.0.0.rc1 on a client codebase, I met a situation where a client-declared module named
DSLExtensions
was shadowed by the newKiba::DSLExtensions
containing the newConfig
.Before this PR, the
Parser
(callinginstance_eval
) was declared like this:As I discovered, just changing the declaration to this instead:
seems to hide the Kiba classes further enough to avoid the conflict mentioned above.
I expect that a better blank-slate approach will likely be needed at some point in the future, but this seem to be good enough for the upcoming v2, and will at least make sure that clients using the
DSLExtensions
module to group DSL extensions (very commonly used by my clients) won't see a conflict due to the introduction ofKiba::DSLExtensions::Config
.