Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid benchmarks #71

Closed
esemplastic opened this issue Sep 8, 2017 · 3 comments
Closed

Invalid benchmarks #71

esemplastic opened this issue Sep 8, 2017 · 3 comments

Comments

@esemplastic
Copy link
Contributor

esemplastic commented Sep 8, 2017

Hello, I've seen your try to make benchmark tests on different type of routers and web frameworks (which is not the same thing , is like comparing apples with cars, but this is your own choice) but this is not a fair benchmark because some web frameworks running from dynamic ipv6/or ipv4 address and some others from static ipv4.

Take for example the the go/gorillamux vs iris vs echo,
go/gorillamux uses regexp while iris uses one of the fastest algorithms for routing (it's well known for that), iris is battle-tested on different type of web applications already, however your benchmark results shows gorilla mux overperform iris and echo, this is not possible because golang's regexp is the slowest method see here http://benchmarksgame.alioth.debian.org/u64q/regexredux.html

EDIT:

Also on Iris you store the path parameter before send it to the client while in echo you send it without storing it to variable, please fix that too.

Thank you!

esemplastic added a commit to esemplastic/which_is_the_fastest that referenced this issue Sep 8, 2017
@unreadable
Copy link
Contributor

@esemplastic I didn't commit any updates to the iris code and after that open that issue. I wanna see where I did those modification. Also @hiveminded, "attack on iris"?? I hope you're kidding here..

tbrand added a commit that referenced this issue Sep 8, 2017
@pjmtdw
Copy link

pjmtdw commented Sep 13, 2017

If changing listening address from :3000 to localhost:3000 really affects the performance, which is done in this commit, I think the this code should also be changed to localhost:3000

@kalicki
Copy link

kalicki commented Jan 22, 2018

Duplicate... Close?!

@tbrand tbrand closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants