Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid versioning npm locks #122

Merged
merged 2 commits into from
Feb 17, 2018
Merged

Avoid versioning npm locks #122

merged 2 commits into from
Feb 17, 2018

Conversation

waghanza
Copy link
Collaborator

No description provided.

@waghanza waghanza mentioned this pull request Feb 15, 2018
Closed
@tbrand tbrand merged commit 60b26a4 into the-benchmarker:master Feb 17, 2018
@tbrand
Copy link
Collaborator

tbrand commented Feb 17, 2018

Thanks!

tbrand pushed a commit that referenced this pull request Feb 20, 2018
@waghanza @tbrand
Add django (#120)
288ffae 
* add a simple example

* add launcher for django

* launch django using python group

* Avoid versioning npm locks (#122)

* npm lock file are json one, not using lock extension

* remove already versionned npm lock files

* update: 20180217

* fix

* fix
@thiamsantos
Copy link
Contributor

Why the locks were removed? The pakage-lock.json should always be committed. More information.

Quoting:

It is highly recommended you commit the generated package lock to source control: this will allow anyone else on your team, your deployments, your CI/continuous integration, and anyone else who runs npm install in your package source to get the exact same dependency tree that you were developing on.

@thiamsantos
Copy link
Contributor

I was looking, all the lockfiles, even for other package managers are been removed. You are experiencing any issues with the lockfiles?

@waghanza
Copy link
Collaborator Author

waghanza commented Apr 29, 2018 •
edited

Hi @thiamsantos,

lock files are removed for this project for node but also for crystal and ruby.

More, I'd say that lock files are recommended for production-ready apps or library, which is not the case here.

Since this tool is creating environments on-the-fly, keeping lock files are irrelevant since the environment and host could differs (language version, for example).

Regards,

PS : The #121 was solved by removing lock files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waghanza @tbrand @thiamsantos