Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lucky compilation #130

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Fix lucky compilation #130

merged 2 commits into from
Feb 24, 2018

Conversation

waghanza
Copy link
Collaborator

Hi,

Lucky compilation fails due to static asset compilation, no need in our use case.

@paulcsmith How can we disable it ?

@tbrand This solution works but only using make, don't now about neph

Regards,

@waghanza waghanza changed the title use makefile to avoid lucky compilation failure Fix lucky compilation Feb 23, 2018
Copy link
Collaborator

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll add the patch for neph.

@tbrand tbrand merged commit 7b6010f into the-benchmarker:master Feb 24, 2018
@paulcsmith
Copy link
Contributor

@waghanza I can add an option to Lucky to disable asset support. I have some other priorities but I'll open a PR here once it is added!

@waghanza
Copy link
Collaborator Author

@paulcsmith ❤️

@waghanza waghanza deleted the fix_lucky_compilation branch February 24, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants