[Japronto] Support multicore #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waghanza
reviewed
Sep 11, 2018
python/japronto/server.py
Outdated
| @@ -18,4 +20,4 @@ def get_user(request): | |||
| app.router.add_route('/user', create_user, 'POST') | |||
| app.router.add_route('/user/{id}', get_user, 'GET') | |||
|
|
|||
| app.run(host='0.0.0.0', port=3000) | |||
| app.run(host='0.0.0.0', worker_num=int(sys.argv[2]), port=3000) | |||
There was a problem hiding this comment.
sys.argv[2] does not exists
There was a problem hiding this comment.
fixed, sorry, I made the change directly in the GitHub interface ... :P
|
@agalera Thanks for your contribution, I've fixed the above mistake. You can give me right write if you want me to fix ❤️ |
|
Awesome, comparing current and master give me those results
🎉 PS : Those tests are done on a |
waghanza
added a commit
that referenced
this pull request
Sep 12, 2018
* use io (stderr chanel) instead of file on benchmark (#365) * [Japronto] Support multicore (#366) * support multicore * Support multicore * fix typo * update koa to 2.5.3 (#367) * setup dependencies.io * specify python version on dependencies.yml * specify python version under x.y.z format for deps
waghanza
added a commit
to qti3e/web-frameworks
that referenced
this pull request
Oct 5, 2018
* use io (stderr chanel) instead of file on benchmark (the-benchmarker#365) * [Japronto] Support multicore (the-benchmarker#366) * support multicore * Support multicore * fix typo * update koa to 2.5.3 (the-benchmarker#367) * setup dependencies.io * specify python version on dependencies.yml * specify python version under x.y.z format for deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.