Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elysia, stricjs and hono #6422

Merged
merged 5 commits into from
Jun 11, 2023
Merged

add elysia, stricjs and hono #6422

merged 5 commits into from
Jun 11, 2023

Conversation

jim-king-2000
Copy link
Contributor

@jim-king-2000 jim-king-2000 commented Jun 9, 2023

Add bun frameworks of elysia, stricjs and hono to the benchmark.

@jim-king-2000 jim-king-2000 changed the title add elysia add elysia, stricjs and hono Jun 9, 2023
@waghanza
Copy link
Collaborator

waghanza commented Jun 9, 2023

@SaltyAom we plan to add elysia in here. Are you not opposed on such a thing ?

@waghanza
Copy link
Collaborator

waghanza commented Jun 9, 2023

@yusuke we plan to introduce hono in here. Are you opposed in such a thing?

@waghanza
Copy link
Collaborator

waghanza commented Jun 9, 2023

@bunsvr we are going to introduce stric in here. Are you opposed on such a thing?

Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for introducing bun @jim-king-2000. You will need to add

bun:
  command: bun run app.ts

in javascript/config.yaml and create a simple dockerfile as javascript/bun.Dockerfile

FROM oven/bun:0.6

WORKDIR /usr/src/app

{{#files}}
  COPY '{{source}}' '{{target}}'
{{/files}}

RUN apt-get -qq update

{{#deps}}
  RUN apt-get -qy install {{{.}}}
{{/deps}}

{{#bootstrap}}
  RUN {{{.}}}
{{/bootstrap}}

{{#environment}}
  ENV {{{.}}}
{{/environment}}

{{#fixes}}
  RUN {{{.}}}
{{/fixes}}

CMD {{{command}}}

javascript/elysia/config.yaml Outdated Show resolved Hide resolved
javascript/elysia/package.json Outdated Show resolved Hide resolved
javascript/hono/config.yaml Outdated Show resolved Hide resolved
javascript/hono/package.json Outdated Show resolved Hide resolved
javascript/stricjs/config.yaml Outdated Show resolved Hide resolved
javascript/stricjs/package.json Outdated Show resolved Hide resolved
@jim-king-2000
Copy link
Contributor Author

Update the pull request.

@waghanza
Copy link
Collaborator

waghanza commented Jun 9, 2023

Thanks @jim-king-2000, let's way a bit before merge (if there is no opposition for any framework in this PR)

@jim-king-2000
Copy link
Contributor Author

Looking forward to the benchmark result. 😊

@waghanza
Copy link
Collaborator

I'll include those project on next run (monday)

@waghanza waghanza merged commit c1d7631 into the-benchmarker:master Jun 11, 2023
46 checks passed
@jim-king-2000
Copy link
Contributor Author

Glad to see it has been merged. I could add more frameworks. May I send the PR directly in the future?

@waghanza
Copy link
Collaborator

Sure. You can propose any framework you want, but please ping the author / core members to see if it is valuable to include it here

@waghanza
Copy link
Collaborator

Those frameworks has been included https://web-frameworks-benchmark.netlify.app/result?f=hono,stricjs,elysia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants