Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Optimize builds #7096

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[PHP] Optimize builds #7096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a3ed55
leverage docker cache
waghanza Dec 31, 2023
b2e0928
change base dir for extensions
waghanza Dec 31, 2023
cc5a03c
remove debug
waghanza Dec 31, 2023
b91267e
typo
waghanza Dec 31, 2023
0fd29b4
install build deps on base php container
waghanza Jan 10, 2024
bcea734
replace path for php ext
waghanza Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,14 @@ def create_dockerfile(directory, engine, config)
end
end

config['extensions']&.map!{{_1 => true, :name => _1}}
config['modules']&.map!{{_1 => true, :name => _1}}

template = File.read(path)
File.write(File.join(directory, ".Dockerfile.#{engine}"), Mustache.render(template, config.merge("files" => files, "static_files" => static_files, "environment" => config["environment"]&.map do |k, v|
"#{k}=#{v}"
end)))
template_data = config.merge("files" => files, "static_files" => static_files, "environment" => config["environment"]&.map do |k, v|
"#{k}=#{v}"
end)
File.write(File.join(directory, ".Dockerfile.#{engine}"), Mustache.render(template, template_data))
end

desc "Create Dockerfiles"
Expand Down
66 changes: 36 additions & 30 deletions php/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,58 @@
{{#language.version}}
FROM php:{{{.}}}-fpm
FROM php:{{{.}}}-fpm AS base
{{/language.version}}
{{^language.version}}
FROM php:8.3-fpm
FROM php:8.3-fpm AS base
{{/language.version}}

RUN apt-get -qq update
RUN apt-get -qy install libzip-dev {{#deps}} {{{.}}} {{/deps}}
RUN apt-get -qy install libzip-dev {{#deps}} {{{.}}} {{/deps}} {{#build_deps}} {{{.}}} {{/build_deps}}
RUN docker-php-ext-install zip opcache

WORKDIR /usr/src/app
{{#modules}}
FROM base AS {{{name}}}
RUN docker-php-ext-install {{{name}}}
{{/modules}}

RUN docker-php-ext-install zip opcache
{{#extensions}}
FROM base AS {{{name}}}
{{#event}}
RUN docker-php-ext-install sockets
{{/event}}
RUN mkdir -p /usr/src/php/ext/{{{name}}}
RUN curl -fsSL https://pecl.php.net/get/{{{name}}} | tar xvz -C "/usr/src/php/ext/{{{name}}}" --strip 1
RUN docker-php-ext-install {{{name}}}
{{/extensions}}

{{#environment}}
ENV {{{.}}}
{{/environment}}
FROM base

{{#build_deps}}
RUN apt-get -qy install {{{.}}}
{{/build_deps}}
WORKDIR /usr/src/app

{{#modules}}
RUN docker-php-ext-install {{{.}}}
COPY --from={{{name}}} /usr/local/lib/php/extensions/no-debug-non-zts-20230831/{{{name}}}.so /usr/local/lib/php/extensions/no-debug-non-zts-20230831/{{{name}}}.so
{{/modules}}

{{#extensions}}
RUN mkdir -p /usr/src/php/ext/{{{.}}}
RUN curl -fsSL https://pecl.php.net/get/{{{.}}} | tar xvz -C "/usr/src/php/ext/{{{.}}}" --strip 1
RUN docker-php-ext-install {{{.}}}
{{#event}}
COPY --from=sockets /usr/local/etc/php/conf.d/docker-php-ext-sockets.ini /usr/local/etc/php/conf.d/docker-php-ext-sockets.ini
COPY --from=sockets /usr/local/lib/php/extensions/no-debug-non-zts-20230831/sockets.so /usr/local/lib/php/extensions/no-debug-non-zts-20230831/sockets.so
{{/event}}

COPY --from={{{name}}} /usr/local/etc/php/conf.d/docker-php-ext-{{{name}}}.ini /usr/local/etc/php/conf.d/docker-php-ext-{{{name}}}.ini
{{#event}}
RUN docker-php-ext-install sockets
RUN sed -i -e '1i extension=sockets.so' /usr/local/etc/php/conf.d/docker-php-ext-event.ini
{{/event}}
COPY --from={{{name}}} /usr/local/lib/php/extensions/no-debug-non-zts-20230831/{{{name}}}.so /usr/local/lib/php/extensions/no-debug-non-zts-20230831/{{{name}}}.so
{{/extensions}}

ENV EVENT_EXT_FILE /usr/local/etc/php/conf.d/docker-php-ext-event.ini
RUN if [ -f "${EVENT_EXT_FILE}" ] ; then \
rm -fr /usr/local/etc/php/conf.d/docker-php-ext-sockets.ini ; \
sed -i -e '1i extension=sockets.so' /usr/local/etc/php/conf.d/docker-php-ext-event.ini ; fi

{{#before_build}}
RUN {{{.}}}
{{/before_build}}
{{#environment}}
ENV {{{.}}}
{{/environment}}

{{#files}}
COPY '{{source}}' '{{target}}'
{{/files}}


{{^framework.standalone}}
{{#bootstrap}}
RUN {{{.}}}
Expand All @@ -64,10 +73,8 @@ RUN if [ -f "${EVENT_EXT_FILE}" ] ; then \
RUN sed -i 's/\(listen =\).*/\1 \/var\/run\/php-fpm.sock/g' /usr/local/etc/php-fpm.d/www.conf
RUN sed -i 's/\;\(listen\.owner.*\).*/\1/g' /usr/local/etc/php-fpm.d/www.conf
RUN sed -i 's/\;\(listen\.group.*\).*/\1/g' /usr/local/etc/php-fpm.d/www.conf
RUN sed -i 's/\;\(listen\.mode.*\).*/\1/g' /usr/local/etc/php-fpm.d/www.conf
# pm.max_children set according to nproc
RUN sed -i 's/\;\(listen\.mode.*\).*/\1/g' /usr/local/etc/php-fpm.d/www.conf\
RUN if [ $(nproc) = 1 ] ; then sed -i 's/\(pm\.max_children =\).*/\1 512/g' /usr/local/etc/php-fpm.d/www.conf ; else sed -i 's/\(pm\.max_children =\).*/\1 1024/g' /usr/local/etc/php-fpm.d/www.conf ; fi
# after 15 seconds warm-up, half of the 'idle' children are not killed
RUN if [ $(nproc) = 1 ] ; then sed -i 's/\(pm\.max_spare_servers =\).*/\1 256/g' /usr/local/etc/php-fpm.d/www.conf ; else sed -i 's/\(pm\.max_spare_servers =\).*/\1 512/g' /usr/local/etc/php-fpm.d/www.conf ; fi

RUN rm -fr /usr/local/etc/php-fpm.d/zz-docker.conf
Expand Down Expand Up @@ -105,5 +112,4 @@ RUN if [ -f "${EVENT_EXT_FILE}" ] ; then \

CMD /usr/local/sbin/php-fpm --daemonize; nginx -g "daemon off;"

{{/command}}

{{/command}}
Loading